Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are there plans to support cupertino? #50

Closed
VictorUvarov opened this issue Apr 22, 2020 · 2 comments
Closed

Are there plans to support cupertino? #50

VictorUvarov opened this issue Apr 22, 2020 · 2 comments

Comments

@VictorUvarov
Copy link

Is your feature request related to a problem? Please describe.
Currently this package only supports material apps. I see ThemeData and MaterialLocalizations being used.

Describe the solution you'd like
Check the platform before using things like ThemeData.

Describe alternatives you've considered
The solution will probably find all the occurrences of material dependencies and add a platform check there.

@jonataslaw
Copy link
Owner

Is your feature request related to a problem? Please describe.
Currently this package only supports material apps. I see ThemeData and MaterialLocalizations being used.

Describe the solution you'd like
Check the platform before using things like ThemeData.

Describe alternatives you've considered
The solution will probably find all the occurrences of material dependencies and add a platform check there.

This library has full support for the cupertino. Even the swipe to back (popGesture) is present.
All route components are also present, the snackbar follows the Human Guidelines (not even Flutter's own snackbar is not doing this), the routes besides using all Cupertino transitions natively on iOS, still makes it possible to do the same on android.
I definitely think you've looked at lines of code and presuppose that, but no, the package is not Material based, and what you saw was just aliases for some functions like the defaultDialog (which this is only material, and will continue to be ).
Having references to the Material code does not mean that it does not support cupertino, it means that it also supports Material.

If you want to use Get with the native iOS dialog, or any iOS widget that uses context, you can still use Get.context or Get.overlayContext (in the case of modals) to do this.

@VictorUvarov
Copy link
Author

Okay thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants