Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken npm package 0.0.3? #1

Closed
bobisjan opened this issue Oct 21, 2015 · 5 comments
Closed

Broken npm package 0.0.3? #1

bobisjan opened this issue Oct 21, 2015 · 5 comments

Comments

@bobisjan
Copy link

Hi,

I'm getting errors when running ember tests like this one:

error Rule 'no-comma-dangle' was removed and replaced by: comma-dangle no-comma-dangle,

I have discovered that package at https://registry.npmjs.org/eslint-config-nightmare-mode/-/eslint-config-nightmare-mode-0.0.3.tgz contains old version of eslint.json (with "no-comma-dangle": 2,) compared with same file on GitHub.

Thanks

@bertdeblock
Copy link

I have the same issue, would be great if you could take a look at it.
Thanks in advance!

@blia
Copy link

blia commented Oct 22, 2015

+1

@jonathanKingston
Copy link
Owner

Super happy people are using this (Other feedback is welcome - more changes were planned before the 1.0.0 release).

The latest version is 0.3.0 which doesn't have this code in. It actually was released straight after 0.0.3.

Is there something depending on such an old version?

@bobisjan
Copy link
Author

I do not use it directly so I can not specify desired version - I've updated ember-cli-eslint to 1.1.0, then brocolli-lint-eslint resolved to 1.1.1 and eslint-config-nightmare-mode resolved to 0.0.3 - I do not why, but I also run rm -rf node_modules and npm cache clean to be sure...

BTW: Thanks for the eslint stuff for ember!

Update: I was confused with GitHub Releases, I've tried to update ember-cli-eslint to 1.2.1, but still got 0.0.3 of this repo.

@bobisjan
Copy link
Author

Sorry, I've overlooked that this repo is a dependency of eslint-config-ember, after updating this package everything look fine except hint errors :-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants