Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share model List Between Functions #48

Open
jonthegeek opened this issue Dec 31, 2019 · 2 comments
Open

Share model List Between Functions #48

jonthegeek opened this issue Dec 31, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@jonthegeek
Copy link
Collaborator

extract_features, download_BERT_checkpoint, and probably some other functions use the model parameter, with a hard-coded list of models. Investigate listing those models in one place and automatically updating the formals of those functions. Ideally it should still list them all in the documentation of that function (and in RStudio autocomplete), so it'll take at least a little bit of fanciness. I'm pretty certain it's possible, though.

@jonthegeek jonthegeek added the enhancement New feature or request label Jan 4, 2020
@jonthegeek
Copy link
Collaborator Author

This could probably relate to #30.

@jonthegeek
Copy link
Collaborator Author

I think the best option here would be to make a function, something like known_models. It would have defaults and information about what models we know how to deal with.

That doesn't feel quite perfect yet, but along those lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant