Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up download_checkpoint #25

Closed
jonthegeek opened this issue Sep 21, 2019 · 1 comment
Closed

Clean up download_checkpoint #25

jonthegeek opened this issue Sep 21, 2019 · 1 comment
Labels
CRAN Issues that must be closed before CRAN submission.

Comments

@jonthegeek
Copy link
Collaborator

As an RBERT user, I'd like downloaded checkpoints to be "stable," so that I can confidently use them for future data prep.

Work out a way to do these things:

  1. Confirm that a checkpoint is the same now as it was when I used it previously.
  2. Preprocess any parts of checkpoints that will be used directly by RBERT (vs BERT), such as the vocab (and then, in the thing that reads in the vocab, identify which type I'm reading).
  3. Allow a user to point to a checkpoint that they downloaded for us to process it.
@jonthegeek jonthegeek added the CRAN Issues that must be closed before CRAN submission. label Sep 24, 2019
@jonthegeek
Copy link
Collaborator Author

jonthegeek commented Oct 22, 2019 •
edited

In the coming PR I don't really do the things in the list. Need to think more about dealing with those things (separate tickets coming as we sort them out).

jonthegeek added a commit to jonthegeek/RBERT that referenced this issue Oct 22, 2019
@jonthegeek
Simplified download_BERT_checkpoint usage. Closes jonathanbratt#25.
1b03a24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CRAN Issues that must be closed before CRAN submission.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonthegeek