Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode error in Acronyms CSV export #106

Closed
ioalexei opened this issue Feb 22, 2024 · 7 comments
Closed

Unicode error in Acronyms CSV export #106

ioalexei opened this issue Feb 22, 2024 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@ioalexei
Copy link

ALA acronym shows correctly as Åland Islands in the table on the website but shows as Ã…land Islands in the CSV export

From a quick scan also affects: BCG, BLM, CHAST, CIV - and probably some others

@JonathanGarro JonathanGarro self-assigned this Feb 22, 2024
@JonathanGarro
Copy link
Owner

thanks @ioalexei i will dig into this

@ioalexei
Copy link
Author

Update on this - with the new functionality from #107 the CSV download now has lots of extra text in the first column - e.g.

Acronym (English)
----------------
AAP                                                                                                  Acronym Details                                                                                                                                English                         AAP                                                                                                                                                                                     Definition                         Accountability to Affected Populations                                                                                                                                                                                                                                                                                                                                                                                     Permalink                                                                                        Close

@ioalexei
Copy link
Author

One more thought on this - at the moment the CSV downloads as SIMS.csv. Could it be something like SIMS-acronyms.csv ?

@JonathanGarro
Copy link
Owner

yikes, didn't notice the export mess. i'll dig into that as part of this issue

@JonathanGarro JonathanGarro added the bug Something isn't working label Feb 28, 2024
@JonathanGarro
Copy link
Owner

@ioalexei I've rebuilt the JS that loads that CSV and pushed it up to prod. Can you take a look and let me know if that solves the data export issue you saw? I also changed the default name of the generated file.

I still need to solve the encoding issue.

@ioalexei
Copy link
Author

@JonathanGarro thanks - looks fixed now, and downloads with the new file name.

@JonathanGarro
Copy link
Owner

great. ive also fixed the utf-8 encoding issue, will appear in the 1.9.2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants