Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Notion API versioning date #7

Merged
merged 2 commits into from Jul 5, 2021
Merged

Add Notion API versioning date #7

merged 2 commits into from Jul 5, 2021

Conversation

bgwastu
Copy link
Contributor

@bgwastu bgwastu commented Jul 2, 2021

When I first using this package, the package did not work because Notion enforcing "Notion-Version" header requirement for all API requests on July 1st. Because of that, I add the header requirement into this package.

Sorry, I didn't do unit testing the code beforehand, I hope it will works just fine.

@jonathangomz
Copy link
Owner

Thaaaanks, I will check this right now, sorry for the delay

@jonathangomz jonathangomz merged commit 4db5cda into jonathangomz:main Jul 5, 2021
@jonathangomz
Copy link
Owner

I don't know why tests with GitHub actions failed, hehe, I'm new to all of this, but on my computer all tests passed. I'm just gonna trust haha

@bgwastu
Copy link
Contributor Author

bgwastu commented Jul 5, 2021

Ahh, okay -- I thought there was a mistake there. BTW, thanks for this package, I learned a lot from it!

@jonathangomz
Copy link
Owner

Me too haha I also learn a lot. Actually, I used this project to learn and practice dart :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants