Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smpl chunk to RIFF when exporting #16

Closed
johndoe46 opened this issue Oct 23, 2016 · 6 comments
Closed

Add smpl chunk to RIFF when exporting #16

johndoe46 opened this issue Oct 23, 2016 · 6 comments

Comments

@johndoe46
Copy link

1/ import wav with smpl chunk
2/ save *.all file
3/ export wav file -> no more smpl chunk (korg loop points are ok though)

@JonathanTaquet
Copy link
Owner

Yes for sure, I voluntarily remove any chunck that is not used by the electribe, because, if I remember well, the electribe notify you with a load error when those chunks are present in the .all file. The electribe does the same when you import samples with it.
But if you need this feature, I can add an export option to translate the korg loop/slice points into smpl/cue chunks.

@johndoe46
Copy link
Author

Ah ! I see... my experience with manually importing wavs (via sd card) with smpl chunks in the e2s was that they were simply ignored, sadly like a lot of hardware and software samplers do these days (and that's why I'm interested in Oe2SLE in the first place... because now I can finally enjoy my carefully looped wavs in the e2s, so thank you for that :) !). Of course, if having such chunks in the *.all file gives errors, you're obviously right to remove them at import.

However, when exporting, this would make perfect sense (for sampler interoperability) to translate loop points. I'm not sure about the need to translate slice points because I don't know any other sampler that would use them, but loop points, yes, I would definitely love a smpl translation for those since my samples often go back and forth between the e2s and Renoise.

Maybe it could be an option of e2s_sample.write() ?

@JonathanTaquet
Copy link
Owner

JonathanTaquet commented Oct 24, 2016

I'm working on it. It should be done tomorrow.
I think that slice points may also be interesting if you want to export sliced samples to use them in a daw (for instance).

@JonathanTaquet
Copy link
Owner

Commits 047df9e and a5fa141 should do the job.

The export of smpl/cue chunks is currently activated for all exported samples.

I will see later to add an option file + an interface to set options. It will let the possibility to disable the export of smpl/cue chunks if one wants.

@johndoe46
Copy link
Author

johndoe46 commented Oct 26, 2016

Works like a charm ! Thank you :-)

@JonathanTaquet
Copy link
Owner

Ok, nice. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants