New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
* { background-color:inherit; } is a major cause of pain #43
Comments
Hey @stereokai, this got arleady removed last month. See 292c630. Please get the latest .scss and compile it for yourself, because the current .css in this repo isn't the latest version. :) (For now, you could also use one of the files from https://github.com/FabianBeiner/sanitize.css/tree/dev/dist, which are the latest version.). |
Cheers. What can we do to get it into npm? |
You'll (probably) have to wait for @jonathantneal. I'm sure he'll answer as soon as he has the time. :) |
Thank you very much. |
@jonathantneal W'sup Johnny? 👍 |
This (background-color: inherit) should not be here. |
I know. When are you pushing it to NPM? |
I just did. |
Resolved in 2.1x |
@jonathantneal
* { background-color: inherit; }
is a major cause of pain for us.Especially in large projects which import components from external projects (read: enterprise scale apps and website).
For example, global components like header, footer, login forms are breaking because of that: for example, transparent elements in a global component, assume undesired background colors from their container element in an app which requires that component.
This has been a major cause of pain for us since we started using sanitize.css, because there is no way to reverse this rule - you'd have to manually add over-riding rules for each HTML element you want to fix - even though the correct background rules are already present in their respective components' stylesheets.
Please consider dropping it, because otherwise we would be forced to drop using sanitize.css, which we favor due to it being great project with a modern approach.
Thanks,
Tom Alon
Wix.com
The text was updated successfully, but these errors were encountered: