-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safari greater 9 (desktop and mobile) downloads the external svg file for every icon on page #110
Comments
Yep, we're experiencing the same bug on every website we're using external SVG sprites in Safari 9+... |
Yep, same here. |
I also made a screencast (in german) showcasing the problem (and a different svg sprite solution). |
@codecandies, @martinwolf, @stefangrund Has anyone filled a bug with webkit about this issue. |
There are open bugs, (maybe | probably) related, like this or this with comments like:
There is also this one with status: RESOLVED WONTFIX 🤔 However, maybe @dirkschulze knows something. |
Yes I have filed a bug already. See https://bugs.webkit.org/show_bug.cgi?id=156368 |
@elrumordelaluz This particular issue was closed because it was filed against Chromium. Chromium doesn't use WebKit anymore but the fork Blink. |
https://bugs.webkit.org/show_bug.cgi?id=156368 got a patch meanwhile, so a fix seems on the way, just not sure when it will land in (mobile) Safari. |
@codecandies On Twitter I read that branching for WWDC was done yesterday. Usually there is another branch for the shipping product later. In any way it should get into the next version of mobile Safari. |
In terms of a fix for this issue in svg4everybody, I'm guessing an addition to the UA detection for the versions of Safari / Mobile Safari? cc/ @jonathantneal |
This was fixed in Safari 9.1.1/IOS 9.3.2. See: https://www.smashingmagazine.com/2016/05/safari-svg-sprite-bug/ Tested it with my projects and can confirm. |
Cool, so good to close then? |
@shawnbot Yep. |
Sweet, thanks everyone! |
This may be a safari bug, but maybe you can dig into this better than me…
In this testcase http://phpscripts.zeit.de/svg-use-testcase/ you can see the problem, by loading and examining it with Chrome and a Safari greater 9 (exact version mentioned on the testcase). The problem is also seen in iOs safari, since 9.2 i guess (inspected with Charles proxy).
The problem
For every combination of the code
the svg file
icons.svg
is (re-)downloaded by safari browsers. Additionally the file is not cached in the browser or ever served from cache, and the developer tools see this file not asimage/svg+xml
but asother
.This leads to extreme high content downloads, which is especially on mobile and may not a good development for svg for everybody, I guess. :(
The text was updated successfully, but these errors were encountered: