Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't make href work using svg4everybody #180

Open
bryanrasmussen opened this issue Jun 6, 2018 · 1 comment
Open

can't make href work using svg4everybody #180

bryanrasmussen opened this issue Jun 6, 2018 · 1 comment

Comments

@bryanrasmussen
Copy link

I can see in the history this should have been fixed in #79
and the code var src = use.getAttribute('xlink:href') || use.getAttribute('href'); ks there, but nonetheless <use href doesn't seem to work in Safari for us.

My colleague is of the opinion that it will not work iwthout xlink, and all of the documentation presumes xlink so I can't get any more hours put towards fixing it. So if indeed it works it would be good to change the documentation to show that both can be used.
Otherwise an issue should be opened to make it work.

@yellow1912
Copy link

You can also try to create a custom attribute such as data-hreft and use svg4everybody({'attributeName': 'data-href', 'polyfill': true}); It works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants