Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce coding standards. #150

Merged

Conversation

raphaelstolt
Copy link
Contributor

Adds a local php-cs-fixer cache and validation during Travis CI builds.

@localheinz
Copy link

localheinz commented Oct 4, 2016

Unfortunately, the caching doesn't work on Travis, but if you dare to use friendsofphp/php-cs-fixer:v2.0.0-alpha, then you can make use of it on Travis, too!

This significantly speeds up build times.

For an example, take a look at https://github.com/refinery29/php-cs-fixer-config/blob/master/.php_cs!

We have been using it for a while, it works fine.

On a separate note, I can't wait for 2.0.0 release of friendsofphp-php-cs-fixer!

😄

For reference, see PHP-CS-Fixer/PHP-CS-Fixer#1076.

@raphaelstolt
Copy link
Contributor Author

@localheinz Thanks for the heads-up. I guess we wait for the 2.0.0 release of friendsofphp-php-cs-fixer, or @jonathantorres should we go experimentell?

@jonathantorres
Copy link
Owner

I wouldn't mind using the alpha version on the construct codebase itself. For the generated project we should use the 2.0.0 release.

@jonathantorres jonathantorres merged commit 299f9c7 into jonathantorres:master Oct 5, 2016
@raphaelstolt
Copy link
Contributor Author

Done with #151. We should prolly create a backlog issue to update the generated project artifacts once 2.0.0 is released.

@raphaelstolt raphaelstolt deleted the php-cs-fixer-improvement branch October 5, 2016 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants