Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors in orth_bert #54

Closed
utsekaj42 opened this issue Jun 22, 2017 · 3 comments
Closed

errors in orth_bert #54

utsekaj42 opened this issue Jun 22, 2017 · 3 comments

Comments

@utsekaj42
Copy link
Contributor

n = cp.Normal(0, 1)
polynomial_order = 3
poly = cp.orth_bert(polynomial_order, n, normed=True)

doesn't work for me.

The first issue was in chaospy/poly/basy.py line 200 was not checking for numpy.int types. I fixed this in my devbranch but now the error occurs when numpy's asarray calss iter . This seemed likely some special edge case for a 1D polynomial expansion, however, trying the following produces the same "not iterable" error. Any ideas on the correct way to fix this?

n = cp.Normal(0, 1)
n = cp.Iid(n,2)
polynomial_order = 3
poly = cp.orth_bert(polynomial_order, n, normed=True)
@jonathf
Copy link
Owner

jonathf commented Jun 22, 2017

The function orth_bert is a legacy feature that I planed to deprecate. (If you look in the development branch, it isn't there anymore.)

If you have a usecase where you need orth_bert, I'll both reinstate it, and fix the corner case. Let me know if that is the case.

@utsekaj42
Copy link
Contributor Author

I don't need it. It was just in a tutorial I was updating. Though it does appear to me that it's still in the development branch (orthogonal.py lines 304ff).

@jonathf
Copy link
Owner

jonathf commented Jun 22, 2017

Ah, sorry, to quick on the trigger finger. The branch I am referring to is jf_pep8 which is my current experimental branch, not development.

Okay, then I consider this a non-issue as the function is about to be removed.

@jonathf jonathf closed this as completed Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants