Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should use .req.ty when checking type of response #15

Closed
jonathonmcmurray opened this issue Jun 26, 2018 · 0 comments
Closed

Should use .req.ty when checking type of response #15

jonathonmcmurray opened this issue Jun 26, 2018 · 0 comments
Assignees
Labels
bug Something isn't working
Projects
Milestone

Comments

@jonathonmcmurray
Copy link
Owner

jonathonmcmurray commented Jun 26, 2018

https://github.com/jonathonmcmurray/reQ/blob/master/req.q#L179

:$[(`j in key`)&r[0][`$"Content-Type"]like .h.ty[`json],"*";.j.k;] r[1];

In this line we use .h.ty to check type of response, but we have .req.ty created by reQ which should be used instead (in case of other modules modifying .h.ty etc. e.g. serve from https://github.com/jonathonmcmurray/qutil_packages )

@jonathonmcmurray jonathonmcmurray added the bug Something isn't working label Jun 26, 2018
@jonathonmcmurray jonathonmcmurray added this to the 0.2.0 milestone Jun 26, 2018
@jonathonmcmurray jonathonmcmurray self-assigned this Jun 26, 2018
@jonathonmcmurray jonathonmcmurray added this to To do in 0.2.0 via automation Jun 26, 2018
0.2.0 automation moved this from To do to Done Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
0.2.0
  
Done
Development

No branches or pull requests

1 participant