Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move decompression to before display for verbose mode #30

Closed
jonathonmcmurray opened this issue Jun 5, 2020 · 0 comments
Closed

Move decompression to before display for verbose mode #30

jonathonmcmurray opened this issue Jun 5, 2020 · 0 comments
Assignees
@jonathonmcmurray
Labels
enhancement New feature or request
Projects
0.2.0
Milestone
0.2.0

Comments

@jonathonmcmurray
Copy link
Owner

Currently, decompression (i.e. gzip decompression in kdb 4.0+) happens in .req.parseresp, meaning that verbose mode shows compressed response.

Should be done in .req.send as soon as response is received.

Should also make it simple to plug in additional handlers for different Content-Encoding types, probably via a dictionary of handlers that can be extended by users.
@jonathonmcmurray jonathonmcmurray added the enhancement New feature or request label Jun 5, 2020
@jonathonmcmurray jonathonmcmurray added this to the 0.2.0 milestone Jun 5, 2020
@jonathonmcmurray jonathonmcmurray self-assigned this Jun 5, 2020
@jonathonmcmurray jonathonmcmurray added this to Done in 0.2.0 via automation Jun 5, 2020
jonathonmcmurray added a commit that referenced this issue Jun 6, 2020
@jonathonmcmurray
gh-30 Only use gzip decompression where available
2057ad3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathonmcmurray jonathonmcmurray

Labels
enhancement New feature or request
Projects
0.2.0
  
Done
Milestone
0.2.0
Development

No branches or pull requests
1 participant
@jonathonmcmurray