Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for localizations #30

Open
jonathontoon opened this issue Feb 3, 2018 · 10 comments

Comments

@jonathontoon
Copy link
Owner

commented Feb 3, 2018

Going to use react-localization. Even though Twitter accounts have a language setting which comes down from the API I think basing the locale off what the computer is using will be the way to go. Will avoid allowing a user to customize their language for now.

Below is a list of all the custom strings supported by Tweet Tray (which cannot already be sourced from Twitter's apps), and a list of which languages require localization.

If you would like to contribute, you can submit a pull request (following these (guidelines)[https://github.com/jonathontoon/tweet-tray#development]) for strings per language found under app/localizations. If the there is not a file for your language (e.g: en-US.json) you can create it as part of the pull request.

Language Status
Arabic (ar)
Bengali (bn)
Czech (cz)
Danish (da)
German (de) ✔️
Greek (el)
Spanish (es) ✔️
Persian (pr)
English (en) ✔️
Finnish (fi)
Filipino (fill)
French (fr) ✔️
Hebrew (he)
Hindi (hi)
Hungarian (hu)
Indonesian (id)
Italian (it)
Japanese (ja) ✔️
Korean (ko) ✔️
Malay (msa)
Dutch (nl)
Norwegian (no)
Polish (pl)
Portuguese (pt)
Romanian (ro)
Russian (ru)
Swedish (sv) ✔️
Thai (th)
Turkish (tr)
Ukrainian (uk)
Urdu (ur)
Vietnamese (vi)
Chinese (Simplified) (zh-CN) ✔️
Chinese (Traditional) (zh-TW) ✔️
@jonathontoon jonathontoon added this to the v2.0.0 milestone Feb 3, 2018
@jonathontoon jonathontoon self-assigned this Feb 3, 2018
@jonathontoon jonathontoon removed this from the v1.5.0 milestone Feb 3, 2018
@harleo

This comment has been minimized.

Copy link
Contributor

commented Feb 3, 2018

I'd be happy to work on German.

@jonathontoon jonathontoon removed their assignment Feb 3, 2018
@jonathontoon jonathontoon added this to To Do in Tweet Tray Feb 6, 2018
@jonathontoon jonathontoon added this to the v1.0.4 milestone Feb 11, 2018
@jonathontoon jonathontoon self-assigned this Feb 16, 2018
@neauoire

This comment has been minimized.

Copy link

commented Feb 16, 2018

Could you link the english localisation file so we can PR it?

@jonathontoon

This comment has been minimized.

Copy link
Owner Author

commented Feb 16, 2018

@neauoire yup, will add it to develop soon. I'd like to support all options for contribution especially for those who aren't comfortable in committing files/making a PR.

@neauoire

This comment has been minimized.

Copy link

commented Feb 16, 2018

Sounds good I'll try to do french & Lietal

@maroun-baydoun

This comment has been minimized.

Copy link

commented Feb 16, 2018

I can help with Arabic translation.
Does the UI support RTL at the moment?

@jonathontoon

This comment has been minimized.

Copy link
Owner Author

commented Feb 16, 2018

@neauoire you can now find the strings under app/localizations in develop. I'm unsure how support for Lietal will work, as everything is based off electron's getLocale() method right now which supports these languages.

@maroun-baydoun I haven't tested RTL yet, but getting all of the strings for such languages is the starting place. I'm honestly expecting some of the UI to break for other languages too, but therein lies the challenge to fix things. 😆

Once strings are in I will make sure they wont ship without RTL support. Unless you'd like to give it a go.

@harleo ready for your help!

@jonathontoon jonathontoon changed the title Add support for multiple locale strings Add support for localizations Feb 16, 2018
@harleo

This comment has been minimized.

Copy link
Contributor

commented Feb 16, 2018

@jonathontoon

This comment has been minimized.

Copy link
Owner Author

commented Mar 9, 2018

@maroun-baydoun any interest still in doing Arabic?

@maroun-baydoun

This comment has been minimized.

Copy link

commented Mar 12, 2018

@jonathontoon Yes, I will do it and send a PR.

@riomarmccartney

This comment has been minimized.

Copy link
Collaborator

commented Feb 11, 2019

Ja related issue: #194

@jonathontoon jonathontoon pinned this issue Jun 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Tweet Tray
  
Done
5 participants
You can’t perform that action at this time.