Skip to content
This repository has been archived by the owner on Oct 9, 2020. It is now read-only.

Prevent multiple oauth windows #87

Closed
jonathontoon opened this issue Feb 9, 2018 · 0 comments
Closed

Prevent multiple oauth windows #87

jonathontoon opened this issue Feb 9, 2018 · 0 comments
Assignees
Labels
bug Something isn't working electron platform/all
Projects
Milestone

Comments

@jonathontoon
Copy link
Owner

Expected Behavior

If an OAuth window has already been presented it should be the only possible instance and remain open until closed.

Current Behavior

I can continue to click the Sign in with Twitter and it keeps opening Twitter OAuth windows.

Possible Solution

Check the OAuthManager has an active window object before creating a new BrowserWindow.

Context

Could possible cause some issues with signing up, but it doesn't stop me from using Tweet Tray, just looks really jank.

Your Environment

Found on develop.

Software Version(s)
Tweet Tray 1.0.2
Windows 10 1709
@jonathontoon jonathontoon added bug Something isn't working electron platform/all labels Feb 9, 2018
@jonathontoon jonathontoon added this to the v1.0.3 milestone Feb 9, 2018
@jonathontoon jonathontoon self-assigned this Feb 9, 2018
@jonathontoon jonathontoon added this to In progress in Tweet Tray Feb 9, 2018
@jonathontoon jonathontoon moved this from In progress to Done in Tweet Tray Feb 9, 2018
@jonathontoon jonathontoon changed the title Multiple OAuth Windows Prevent multiple oath windows Feb 10, 2018
@jonathontoon jonathontoon changed the title Prevent multiple oath windows Prevent multiple oauth windows Feb 10, 2018
@jonathontoon jonathontoon mentioned this issue Feb 10, 2018
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working electron platform/all
Projects
No open projects
Tweet Tray
  
Done
Development

No branches or pull requests

1 participant