Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splash images show substantial aliasing #598

Closed
esDotDev opened this issue Oct 5, 2023 · 5 comments
Closed

Splash images show substantial aliasing #598

esDotDev opened this issue Oct 5, 2023 · 5 comments

Comments

@esDotDev
Copy link

esDotDev commented Oct 5, 2023

The images produced with this library show a lot of aliasing:
image

We would hope for it to look more like:
image

It looks like the AVERAGE mode might be better than CUBIC for down-scaling images:
brendan-duncan/image#23

Maybe this can be made into a config option?

@jonbhanson
Copy link
Owner

jonbhanson commented Oct 15, 2023

I chose Interpolation.cubic because in the image package, it is described as the highest quality :

/// Cubic blend between the neighboring pixels. Slowest, highest Quality.

As long as the image package has that description, I believe this package should use the cubic mode. If your image is not resized with the highest quality, I suggest that you should open a ticket with the image package.

@esDotDev
Copy link
Author

Yes, but if you read the linked thread, they added AVERAGE mode specifically because cubic is quite poor when down-scaling.

Could you expose this setting so developers can choose the mode that best makes sense for their assets?

@esDotDev
Copy link
Author

esDotDev commented Oct 16, 2023

For example, here is CUBIC (left) vs AVERAGE (right) when downscaling a large image:
image

Zooming in on the image really shows the poor anti-aliasing of CUBIC
image

@jonbhanson
Copy link
Owner

OK, I read through that thread more carefully and I see what you mean. I am more inclined to just use AVERAGE rather than make it a developer option. I would like to avoid option bloat, and this choice appears to have a clear winner.

@esDotDev
Copy link
Author

Works for me, thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants