New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quarter sized screen in application window (SDL2 version) #2478
Comments
may be related to #2180 |
This issue is probably related to DPI handling in macOS. The macOS binaries uploaded by @emendelson earlier seemed to fix the issue before (according to another user anyway), but I run macOS only through VM and cannot confirm this myself (nor I have a full solution for this). |
If it's the same issue on my Macbook, moving the window somehow fixes it, until it resizes the window again on a mode change. Not sure what's going on here yet. |
@Wengier I think I'm the other user you refer to. I just tried again with 0.83.9, and it continues to work fine for me, whereas other, later releases give the same issue seen the the screen above. It might be worthwhile for others to try out that release and see if they are experiencing the same thing I am. |
I've also been bitten by this bug, and I tried to get to a previous commit that was good, but I got as far as 0.82.11 and still got the same issue. I suspected library issues at this point but the thing is I've been running dosbox-x for a while without issues (can't remember the specific commit unfortunately) and without changing any libraries on my system, so at this point I'm really baffled (unless dosbox-x is being compiled with static libraries, which might explain this if there is some kind of bug on SDL2 that got introduced recently but my previous copy of dosbox-x was impervious to because libraries were baked in). |
The problem, as far as I ran into this with SDL 1.2 and the incomplete fix based on DOSBox-X libsdl-org/SDL-1.2#839 (comment), is the SDK. And that's why it suddenly stopped working and you can't bisect it. |
Thanks for the information! So I guess the macOS binaries previously uploaded by @emendelson were built with macOS SDK that is free of this issue, which is why the exact same DOSBox-X code may or may not have this problem. |
Confirming the issue on 0.74-3 on M1 arm64 MacBook Pro |
Steps to reproduce the behavior
from 0.83.7 to 0.83.12 (Arm or Intel based)
Expected behavior
Full-sized screen in a window
Environment
The text was updated successfully, but these errors were encountered: