Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quarter sized screen in application window (SDL2 version) #2478

Open
iliadmitriev opened this issue Apr 24, 2021 · 9 comments
Open

quarter sized screen in application window (SDL2 version) #2478

iliadmitriev opened this issue Apr 24, 2021 · 9 comments

Comments

@iliadmitriev
Copy link

iliadmitriev commented Apr 24, 2021

Steps to reproduce the behavior

  1. Download any SDL2 build
    from 0.83.7 to 0.83.12 (Arm or Intel based)
  2. Run
  3. Quarter sized screen

screenshot

Expected behavior
Full-sized screen in a window

Environment

  • MacBook Pro M1 '13 (also tested on Intel based MacBook Pro '13 2019)
  • Operating system MacOS BigSur (also tested on Catalina)
  • DOSBox-X from 0.83.7 to 0.83.12
  • Configuration file is default (empty)
@iliadmitriev
Copy link
Author

dosbox-x.txt

@iliadmitriev
Copy link
Author

may be related to #2180

@Wengier
Copy link
Collaborator

Wengier commented Apr 24, 2021

This issue is probably related to DPI handling in macOS. The macOS binaries uploaded by @emendelson earlier seemed to fix the issue before (according to another user anyway), but I run macOS only through VM and cannot confirm this myself (nor I have a full solution for this).

@joncampbell123
Copy link
Owner

If it's the same issue on my Macbook, moving the window somehow fixes it, until it resizes the window again on a mode change.

Not sure what's going on here yet.

@dixius99
Copy link

dixius99 commented May 3, 2021

@Wengier I think I'm the other user you refer to. I just tried again with 0.83.9, and it continues to work fine for me, whereas other, later releases give the same issue seen the the screen above. It might be worthwhile for others to try out that release and see if they are experiencing the same thing I am.

@Arcnor
Copy link

Arcnor commented May 10, 2021

I've also been bitten by this bug, and I tried to get to a previous commit that was good, but I got as far as 0.82.11 and still got the same issue. I suspected library issues at this point but the thing is I've been running dosbox-x for a while without issues (can't remember the specific commit unfortunately) and without changing any libraries on my system, so at this point I'm really baffled (unless dosbox-x is being compiled with static libraries, which might explain this if there is some kind of bug on SDL2 that got introduced recently but my previous copy of dosbox-x was impervious to because libraries were baked in).

@DominusExult
Copy link

The problem, as far as I ran into this with SDL 1.2 and the incomplete fix based on DOSBox-X libsdl-org/SDL-1.2#839 (comment), is the SDK. And that's why it suddenly stopped working and you can't bisect it.
Build against SDK 10.14 and you should be fine. If you are not using the DOSBox-X SDL2 you will need to build SDL2 also with SDK 10.14.
Of course this only works for intel macOS, as for Apple's ARM64 you need the SDK 11.x :(

@Wengier
Copy link
Collaborator

Wengier commented Jul 20, 2021

Thanks for the information! So I guess the macOS binaries previously uploaded by @emendelson were built with macOS SDK that is free of this issue, which is why the exact same DOSBox-X code may or may not have this problem.

@Firewalker2600
Copy link

Confirming the issue on 0.74-3 on M1 arm64 MacBook Pro
Also interestingly, when using an external monitor, the window work as intended, Dosbox takes full advantage of the window.
It is the native screen of the MacBook Pro that produces this issue when it is without external screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants