You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While taking raw screenshots for #4753, I noticed two problems with the saved png files:
There are duplicated pixels. Raw screenshots are supposed to be a direct copy of the video memory, without any sort of scaling
The Pixel Aspect Ratio metadata is not being stored in the png files, causing them to be viewed with square pixels on viewers that support PixelAspect Ratio, like XnView and the Win 10 image viewer.
Example:
Steps to reproduce the behaviour
Run any DOS game. Preferably EGA 640x200 or 640x350 games, where the issue is more evident
Take a raw screenshot using the Capture menu
Expected behavior
The raw screenshot should be a raw dump from the video memory, without any form of scaling
The Pixel Aspect Ratio metadata (PNG pHYs chunk) should be stored in the file
At this moment, the raw capture mode is more of a direct capture of the pixel values as rasterized by the monitor, so if you're using a 200-line graphics mode on VGA, and the VGA is doubling each scan line as VGA normally does in those modes, then the raw capture will contain the raw pixel values, scan line doubled.
Good point on the aspect ratio fields though, I think I can figure out how to use libpng to write that.
I'm sorry if "raw" is confusing in that it's not exactly a snapshot of video memory, but only a snapshot of the raw pixel values from video memory as they are rasterized to the screen.
Describe the bug
While taking raw screenshots for #4753, I noticed two problems with the saved png files:
Example:
Steps to reproduce the behaviour
Expected behavior
dosbox-staging already implemented this on their raw screenshots.
Example (please view the image using XnView, since it supports the Pixel Aspect Ratio metadata to render rectangular pixels):
What operating system(s) this bug have occurred on?
macOS 13.6.3
What version(s) of DOSBox-X have this bug?
2023.10.06
Used configuration
No response
Output log
No response
Additional information
No response
Have you checked that no similar bug report(s) exist?
Code of Conduct & Contributing Guidelines
The text was updated successfully, but these errors were encountered: