-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shades of gray not supported? #3
Comments
+1 |
@joncardasis Ideally this is something I would like to have as well. Maybe it is something we can work on together? |
I've played with the idea before (I'm just getting to maintaining some older projects atm like this one). I'm curious of how shades of gray could be supported with the current design of the control since the ring is based on hue and the slider is based on intensity and blends between black and white. The picker should be able to select a gray color @V-FEXrt One idea I came up with is this: When the handle is lifted up and if a If the handle is moved to the center button (using CGRects contains(_ :) method) the handle color changes to gray and if let go it will go back to the original lifted space on the circle and become gray. The shade slider would work just fine from there. This would require quite a bit of rework as to how the control functions and making sure everything 'snaps' into place. @V-FEXrt how does this appeal to you? Any suggestions are welcome 😸 |
Sitting on the idea I found one I think I'll be implementing soon. What I am now planning to do:
This way it is optional to implement, minimal effort, doesn't break the current design pattern, and allows for shades of gray. |
Hmm, I really like the first suggestion, but the second one seems more reasonable, and perfectly acceptable for what I need. Is there anything in the implementation that you would like me to help with? |
@V-FEXrt I just went ahead and merged to master. Hopefully, this solution will work for those who need shades of gray 👍 |
I am closing this issue as gray shades are now supported :) |
Looks great! |
Shades of gray not supported?
The text was updated successfully, but these errors were encountered: