Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove add-file, remove-file, and reset-context commands #623

Conversation

cvchaparro
Copy link
Contributor

Description

Remove the add-file, remove-file, and reset-context commands from the active-context plugin.
Additionally, remove the files, and definitions sections from the state.json file.

Linked Items:

Closes #576

Type of change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Feature improvement

Feature Additions

  • None

Bug Fixes

  • Update GitHub CodeQL analysis action version from v1 to v2.

Breaking Changes

  • Remove add-file, remove-file, and reset-context commands.
  • Remove files, and definitions from active context state file.

Feature Improvement Changes

  • None

Checklist:

  • Updated documentation accordingly.
  • My changes generate no new warnings.
  • Have updated new and existing unit tests accordingly.
  • Linked associated items to be closed.
  • Have you bumped the version if there will be a release?

@cvchaparro cvchaparro self-assigned this Jun 20, 2023
Get an initialized LanguageContext with only the core spec since we want to load
plugins from the state file.
Copy link
Contributor

@Coffee2Bits Coffee2Bits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It's nice not running into the stickier edges of the persistence.

Import state seems a dash useless for now, but I don't think it'll be an issue leaving it there while we continue to improve our understanding of the value we need to drive with persistence.

@lizzcondrey lizzcondrey merged commit 818650c into main Jun 20, 2023
21 checks passed
@lizzcondrey lizzcondrey deleted the 576-i-dont-want-persistence-to-maintain-the-files-definitions-in-the-context branch June 20, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I don't want persistence to maintain the files/definitions in the context
3 participants