Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runner#stop raises an exception #407

Closed
kleinron opened this issue Sep 2, 2019 · 2 comments
Closed

Runner#stop raises an exception #407

kleinron opened this issue Sep 2, 2019 · 2 comments

Comments

@kleinron
Copy link
Contributor

kleinron commented Sep 2, 2019

Runner#stop calls server-engine's stop method. The latter expects graceful argument, which is not provided.

As a temp workaround I redefined as follows:

module Sneakers
  class Runner
    def stop(graceful=true)
      @se.stop(graceful)
    end
  end
end
@gabrieljoelc
Copy link
Collaborator

@kleinron thanks for the suggestion. wanna open a PR? 🙏

@gabrieljoelc
Copy link
Collaborator

Closed via #409

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants