Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] fix layers 5 and 2 swapped depth dimension #352

Merged
merged 1 commit into from Jun 10, 2021

Conversation

cjayb
Copy link
Collaborator

@cjayb cjayb commented Jun 10, 2021

Closes #351

@cjayb cjayb requested a review from jasmainak June 10, 2021 16:00
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2021

Codecov Report

Merging #352 (ad09cf4) into master (c65bc1e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #352   +/-   ##
=======================================
  Coverage   90.94%   90.94%           
=======================================
  Files          13       13           
  Lines        2540     2540           
=======================================
  Hits         2310     2310           
  Misses        230      230           
Impacted Files Coverage Δ
hnn_core/network.py 93.14% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c65bc1e...ad09cf4. Read the comment docs.

@cjayb cjayb requested review from ntolley and rythorpe June 10, 2021 16:09
@cjayb cjayb changed the title FIX layers 5 and 2 swapped depth dimension [MRG] fix layers 5 and 2 swapped depth dimension Jun 10, 2021
@cjayb cjayb mentioned this pull request Jun 10, 2021
12 tasks
@cjayb
Copy link
Collaborator Author

cjayb commented Jun 10, 2021

Hmm, digging a little deeper, what's this doing @rythorpe:

dy = self.pos[2] - self.p_secs['soma']['sec_pts'][0][1]

So net.pos_dict contains coordinates such that apical=Z, and Cell flips Z and Y so that apical sections are along Y?

Man it's hard to keep track of all these flips splattered all over the place! I'm honestly uncertain which way our dendrite section s are pointing!

@jasmainak
Copy link
Collaborator

yeah, this is what I saying here @rythorpe

@jasmainak jasmainak merged commit f84f3cf into jonescompneurolab:master Jun 10, 2021
@jasmainak
Copy link
Collaborator

Thanks @cjayb ! Feel free to add a whats_new entry for this in your LFP pull request.

@rythorpe
Copy link
Contributor

Just getting caught up - good catch here @cjayb! Looks like @jasmainak is dismantling the tyranny of incongruent morphology orientation in his most recent PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

L5 cells are ABOVE L2 cells
4 participants