Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] FIX: allow reading experimental dipole #421

Merged
merged 1 commit into from Aug 29, 2021

Conversation

jasmainak
Copy link
Collaborator

closes #420

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2021

Codecov Report

Merging #421 (54c1e63) into master (7c48e69) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 54c1e63 differs from pull request most recent head 71fc1e6. Consider uploading reports for the commit 71fc1e6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #421      +/-   ##
==========================================
+ Coverage   88.40%   88.44%   +0.03%     
==========================================
  Files          18       18              
  Lines        3235     3246      +11     
==========================================
+ Hits         2860     2871      +11     
  Misses        375      375              
Impacted Files Coverage Δ
hnn_core/dipole.py 91.44% <100.00%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c48e69...71fc1e6. Read the comment docs.

Copy link
Contributor

@rythorpe rythorpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does anyone else want to take a look or shall we merge?

@rythorpe
Copy link
Contributor

I'm going to go ahead and merge this to maintain forward momentum. Thanks @jasmainak!

@rythorpe rythorpe merged commit 3bea651 into jonescompneurolab:master Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

read_dipole fails with file in HNN repository
3 participants