[MRG] add drive warnings

[orbekolo]

Closes #269

[ntolley]

@orbekolo this would be a good place to add a test for checking if the warning message is raised:

hnn-core/hnn_core/tests/test_network.py

Line 477 in b630f93

with pytest.warns(UserWarning, match='No connections'):

This function checks if a warning is raised when there are no connections in the local network. You can modify the same code to check if your warning for the drives is raised. match is just a criteria for the test to pass, as in some part of the warning message must contain that string.

After that function indicated, you can use net.add_connection() to add any connection (and avoid the no connections warning). On the next line you can add the with pytest.warns..., and inside the test you can run simulate_dipole(). The drives warning should be raised since net.clear_drives() is called just a few lines up.

[jasmainak]

have you read the contributing guide: https://github.com/jonescompneurolab/hnn-core/blob/master/doc/contributing.rst

As you are going through the process, it would be great to have your feedback on this and potentially improve upon it

[jasmainak]

@orbekolo just checking in here. Do you need help? We're going to revamp the contributing guide ... any feedback would be most welcome!

[codecov-commenter]

Codecov Report

Merging #516 (0ca7aba) into master (908c818) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 0ca7aba differs from pull request most recent head 150f21e. Consider uploading reports for the commit 150f21e to get more accurate results

@@            Coverage Diff             @@
##           master     #516      +/-   ##
==========================================
- Coverage   91.43%   91.41%   -0.02%     
==========================================
  Files          22       21       -1     
  Lines        4157     4149       -8     
==========================================
- Hits         3801     3793       -8     
  Misses        356      356              

Impacted Files	Coverage Δ
hnn_core/dipole.py	92.50% <100.00%> (+0.09%)	⬆️
hnn_core/__init__.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[ntolley]

@orbekolo for some reason the changes to whats_new.rst didn't get updated here. You may need to try git commit-ing the file again and push again.

[jasmainak]

@chenghuzi I let you merge if you're happy!

[chenghuzi]

@chenghuzi I let you merge if you're happy!

LGTM!

[ntolley]

@orbekolo congrats on the first PR merged! 🎉 🎉