Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Fix legacy param reading for legacy_mode=False #614

Merged
merged 2 commits into from Mar 11, 2023

Conversation

ntolley
Copy link
Contributor

@ntolley ntolley commented Mar 10, 2023

@rythorpe @jasmainak I think I figured out the issue with creating a network from a params file when legacy_mode=False. In the file there are "dummy drives" where the tstart comes after tstop so that the drive never occurs in the simulation.

I just added a conditional statement to skip over these drives when they come up, if you see a more elegant solution let me know!

@rythorpe rythorpe added this to the 0.3 milestone Mar 10, 2023
Copy link
Contributor

@rythorpe rythorpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! Don't forget to update whats_new.rst!

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2023

Codecov Report

Merging #614 (7c32057) into master (b9a09d8) will increase coverage by 0.05%.
The diff coverage is 75.00%.

❗ Current head 7c32057 differs from pull request most recent head 349008e. Consider uploading reports for the commit 349008e to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #614      +/-   ##
==========================================
+ Coverage   92.14%   92.19%   +0.05%     
==========================================
  Files          22       22              
  Lines        4225     4229       +4     
==========================================
+ Hits         3893     3899       +6     
+ Misses        332      330       -2     
Impacted Files Coverage Δ
hnn_core/drives.py 97.87% <75.00%> (-0.67%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jasmainak jasmainak merged commit d5d1a03 into jonescompneurolab:master Mar 11, 2023
7 checks passed
@jasmainak
Copy link
Collaborator

Thanks @ntolley !! This is great! @chenghuzi do you think you can use this in the GUI now?!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants