[MRG] Fix legacy param reading for legacy_mode=False #614
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rythorpe @jasmainak I think I figured out the issue with creating a network from a params file when
legacy_mode=False
. In the file there are "dummy drives" where thetstart
comes aftertstop
so that the drive never occurs in the simulation.I just added a conditional statement to skip over these drives when they come up, if you see a more elegant solution let me know!