Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Travis/Appveyor to master branch? #17

Closed
levisc8 opened this issue Feb 6, 2018 · 3 comments
Closed

Add Travis/Appveyor to master branch? #17

levisc8 opened this issue Feb 6, 2018 · 3 comments

Comments

@levisc8
Copy link
Collaborator

levisc8 commented Feb 6, 2018

Since we need a stable master branch for workshops (and since the master branch is now stable after a807f7a!), does it make sense to add continuous integration to make sure all pushes/pull requests to master are checked properly? If you're interested, you can read more on what continuous integration does in jonesor/Rage#9 and here.

If so, @jonesor (or someone else with administrative privileges) will need to activate it from the Github page (Settings -> Integrations & Services). From there, you can grant access to Travis-CI and it should redirect you to the Travis homepage so you can activate it from that end as well. Once that account is activated, I can set up the .travis.yml file.

Thoughts?

@jonesor
Copy link
Owner

jonesor commented Feb 8, 2018

I have done this now. I've used just the default options, so please go ahead and make changes to the yml file if you think it is necessary.

@levisc8
Copy link
Collaborator Author

levisc8 commented Feb 8, 2018

Cool, thanks for letting me know! I'll set it up to build on r-release and r-oldrelease later tonight.

It may be worthwhile to add Appveyor support to cover all of operating system X R version combos (it builds with 3 versions of R on Windows). Setting it up is basically the same as setting up travis, just run devtools::use_appveyor() instead and follow the directions.

@jonesor
Copy link
Owner

jonesor commented Feb 8, 2018

AppVeyor sounds neat. I've added it.
Thanks for taking a look later!

@levisc8 levisc8 closed this as completed in 6634cdd Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants