Add 400 error handling

jemgold · Mar 20, 2014 · ef1a733 · ef1a733
1 parent 7d8ac20
commit ef1a733
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/lib/littleprinter.js b/lib/littleprinter.js
@@ -24,6 +24,9 @@ littleprinter.edition = function(req, res) {
 
   littleprinter.handler.edition(localDeliveryTime, deliveryCount, other, function(e, data) {
     if(e) {
+      if (e === 400) {
+        return res.send(400);
+      }
       return res.send(500);
     }
 
@@ -100,4 +103,4 @@ littleprinter.createEtag = function(s) {
     return hash.digest('hex');
 };
 
-module.exports = littleprinter;
+module.exports = littleprinter;
diff --git a/test/littleprinter_edition_test.js b/test/littleprinter_edition_test.js
@@ -20,6 +20,11 @@ describe('using littleprinter', function() {
       littleprinter.edition(req, res);
       assert(littleprinter.handler.edition.withArgs('LDT', 'DC', req.query).calledOnce);
     });
+    it('should return 400 if handler says so', function() {
+      littleprinter.handler.edition.yields(400);
+      littleprinter.edition(req, res);
+      assert(res.send.withArgs(400).calledOnce);
+    });
     it('should return 500 if handler errors', function() {
       littleprinter.handler.edition.yields('ERROR');
       littleprinter.edition(req , res);
@@ -76,4 +81,4 @@ describe('using littleprinter', function() {
       assert.equal(res.send.firstCall.args[0], '304');
     });
   });
-});
+});