Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have to reload when scss is changed #32

Closed
NAMU1105 opened this issue Oct 9, 2022 · 7 comments · Fixed by #55
Closed

Have to reload when scss is changed #32

NAMU1105 opened this issue Oct 9, 2022 · 7 comments · Fixed by #55
Labels
bug Something isn't working

Comments

@NAMU1105
Copy link

NAMU1105 commented Oct 9, 2022

Hi, thanks for the good template.

I was working on this template and found out that
I need to reload the extension file on chrome://extension to see the updated .scss file

can you improve on this?

thank you

@github-actions
Copy link

github-actions bot commented Oct 9, 2022

Thank you for your contribution. We will check and reply to you as soon as possible.

@Jonghakseo
Copy link
Owner

Sorry for my late reply. Can you tell me in detail under what circumstances hmr doesn't work?

record.mov

If possible, I would appreciate it if you could test it with the latest version and let me know.

@nerdchanii
Copy link

nerdchanii commented Mar 1, 2023

Hello! First of all, thank you for making a good template. Thanks to you, I was able to get started easily.

I am also experiencing the same problem as the issue, so I leave an issue.

as you reproduced above, css is working well with HMR with newTab, popup, option. However, it is not applied when the scss file under /content is changed in the process of working.

So now, we have to manually reload the extensions.

reproduce

reproduce.mov

Lastly, thank you for your hard work on a good project.

@Jonghakseo Jonghakseo linked a pull request Mar 8, 2023 that will close this issue
@Jonghakseo
Copy link
Owner

Jonghakseo commented Mar 8, 2023

@nerdchanii

Thanks for posting the replay video. This issue has been resolved in the PR below, and the style of contentScript is now updated normally.

2023-03-08.11.18.27.mov

@nerdchanii
Copy link

@Jonghakseo Oh! Looks so cool! Thanks you, I appreciate your works 🙇🏻

@Jonghakseo Jonghakseo added the bug Something isn't working label Mar 10, 2023
@Jonghakseo
Copy link
Owner

@all-contributors please add @NAMU1105 for bug

@allcontributors
Copy link
Contributor

@Jonghakseo

I've put up a pull request to add @NAMU1105! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants