Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to build on arm #112

Open
bk2204 opened this issue Nov 6, 2022 · 1 comment
Open

Fails to build on arm #112

bk2204 opened this issue Nov 6, 2022 · 1 comment

Comments

@bk2204
Copy link

bk2204 commented Nov 6, 2022

As mentioned in the docs for std::sync::atomic, AtomicI64 isn't portable because not all systems have 64-bit atomics. At least 32-bit ARM, PowerPC, and MIPS do not, and I'd like to both use Flurry and support those architectures (my supported architectures are those of Debian where Rust is available).

Is it possible that the AtomicI64 could be an AtomicIsize here to better accommodate 32-bit platforms?

@jonhoo
Copy link
Owner

jonhoo commented Nov 7, 2022

So, maybe. The problem with doing that is that a 32-bit counter here could much more reasonably overflow. I would potentially recommend falling back to a RwLock<HashMap> on those platforms instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants