Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialization support #15

Closed
jonhoo opened this issue Jan 23, 2020 · 8 comments
Closed

Serialization support #15

jonhoo opened this issue Jan 23, 2020 · 8 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone
1.0

Comments

@jonhoo
Copy link
Owner

jonhoo commented Jan 23, 2020

We should add support for serde::{Serialize, Deserialize}. The serde docs on custom implementations may be helpful, and the hashbrown implementation almost certainly will be.
@jonhoo jonhoo added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jan 23, 2020
@ghost
Copy link

ghost commented Jan 23, 2020

I am very new to Rust. But I would like to help.

@jonhoo jonhoo added this to the 1.0 milestone Jan 31, 2020
@jonhoo
Copy link
Owner Author

jonhoo commented Feb 17, 2020

@holocenian Did you end up picking this up? :)

@GarkGarcia
Copy link
Contributor

GarkGarcia commented Mar 27, 2020 •
edited
Loading

@jonhoo Your idea is to implement serialization/deserialization for all four data structures exposed by the crate?

@jonhoo
Copy link
Owner Author

jonhoo commented Mar 27, 2020

Yeah, that seems reasonable for Serialize. I'd just stick the main impl on the Ref types, and then have the non-Ref impls just call self.pin().serialize. Deserialize I think should only be on HashMap and HashSet.

@GarkGarcia
Copy link
Contributor

Makes sense. I'll work on that.

@GarkGarcia GarkGarcia mentioned this issue Mar 27, 2020
Merged
@GarkGarcia
Copy link
Contributor

GarkGarcia commented Mar 27, 2020 •
edited
Loading

Should we make serialization support option (via a feature)?

@jonhoo
Copy link
Owner Author

jonhoo commented Mar 27, 2020

Yes, my inclination would be to make it optional and off by default.

@jonhoo
Copy link
Owner Author

jonhoo commented Apr 4, 2020

Fixed in #79 🎉

@jonhoo jonhoo closed this as completed Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@jonhoo @GarkGarcia