You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When implementing inferno-collapse-perf, we made the decision not to strip ' and ". I believe the Perl version did that to not have to deal with them in SVG output, but we should make sure that we actually produce sensible output even with those characters (Rust code with lifetimes for example).
The text was updated successfully, but these errors were encountered:
I created a flame graph with a file that has a Rust stack line with lifetimes, and a contrived line that contains both single and double quotes. The output looks good to me.
Input File
rustc;<rustc::hir::intravisit::IdRangeComputingVisitor<'a, 'hir> as rustc::hir::intravisit::Visitor<'hir>>::visit_id 60
strange;"line";with;"quotes;'foo';'bar 40
When implementing
inferno-collapse-perf
, we made the decision not to strip'
and"
. I believe the Perl version did that to not have to deal with them in SVG output, but we should make sure that we actually produce sensible output even with those characters (Rust code with lifetimes for example).The text was updated successfully, but these errors were encountered: