Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test our decision to include ' and " in collapsed output #34

Closed
jonhoo opened this issue Feb 5, 2019 · 2 comments
Closed

Test our decision to include ' and " in collapsed output #34

jonhoo opened this issue Feb 5, 2019 · 2 comments
Labels
help wanted Extra attention is needed info-needed Further information is requested

Comments

@jonhoo
Copy link
Owner

jonhoo commented Feb 5, 2019

When implementing inferno-collapse-perf, we made the decision not to strip ' and ". I believe the Perl version did that to not have to deal with them in SVG output, but we should make sure that we actually produce sensible output even with those characters (Rust code with lifetimes for example).

@jonhoo jonhoo added help wanted Extra attention is needed info-needed Further information is requested labels Feb 5, 2019
@jasonrhansen
Copy link
Collaborator

I created a flame graph with a file that has a Rust stack line with lifetimes, and a contrived line that contains both single and double quotes. The output looks good to me.

Input File

rustc;<rustc::hir::intravisit::IdRangeComputingVisitor<'a, 'hir> as rustc::hir::intravisit::Visitor<'hir>>::visit_id 60
strange;"line";with;"quotes;'foo';'bar 40

Flame Graph
image

@jonhoo
Copy link
Owner Author

jonhoo commented Mar 2, 2019

Excellent, thanks for investigating! I'll close this then.

@jonhoo jonhoo closed this as completed Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed info-needed Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants