Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SmallVec in favor of using a long-term Vec #80

Closed
jonhoo opened this issue Mar 10, 2019 · 0 comments
Closed

Remove SmallVec in favor of using a long-term Vec #80

jonhoo opened this issue Mar 10, 2019 · 0 comments

Comments

@jonhoo
Copy link
Owner

jonhoo commented Mar 10, 2019

See #78 (comment). Specifically, currently we use a SmallVec for temporarily holding inlined java method calls:

let mut java_inline =
SmallVec::<[String; 1]>::with_capacity(rawfunc.split("->").count() + 1);

However, in #78, @Licenser decided to instead re-use a Vec in the Folder, which seems like a better strategy since it generally won't allocate even if there are inlined method calls (unlike SmallVec, which will allocate every time that happens).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant