Issue with scope string

[alhajrahmoun]

Hi there,
I'm trying to use this gem in my project and I noticed a strange behavior in the Favoritor methods.
I could favorite a favoritable item successfully but I couldn't get the favorites_count, remove_favorite or favorited? results.
after some checking, I found that the scope string is saved "favorite" in the database but when trying to select from the Favorite table you pass the string "Favorite" which means you'll get 0 results as the strings are not identical.

Thank you.

[jonhue]

I looked into this and cannot see a case in which this gem would select Favorites instead of favorites. Perhaps I am just missing your point though. Please provide some information for me to reproduce and I will be happy to reopen this ticket.

[alhajrahmoun]

Let's say we have a user and a book
when a user favorite a book the scope string is saved favorite with small 'f'
but when trying to use remove_favorite on the same book, you are looking for the record using the parameter ["scope", "Favorite"] which means you will get no records and the remove_favorite will return nil.
this is the same case with favorites_count and favorited?.

[jonhue]

Unless you are explicitly setting the scope to Favorite, this gem will neither use it to store nor to retrieve favorites.

[alhajrahmoun]

No, I'm not setting the scope to Favorite

[alhajrahmoun]

Okay..
I did some testing using rails console with the following cases:
1- using the gem from this repository
when running user.favorite book
I got Favorite Load (0.4ms) SELECT "favorites".* FROM "favorites" WHERE "favorites"."favoritor_id" = $1 AND "favorites"."favoritor_type" = $2 AND "favorites"."favoritable_id" = $3 AND "favorites"."favoritable_type" = $4 AND "favorites"."scope" = $5 ORDER BY "favorites"."id" ASC LIMIT $6 [["favoritor_id", 21], ["favoritor_type", "User"], ["favoritable_id", 7], ["favoritable_type", "Book"], ["scope", "favorite"], ["LIMIT", 1]]
then it will do the INSERT operation.

now, when trying to remove_favorite I got:
Favorite Load (0.8ms) SELECT "favorites".* FROM "favorites" WHERE "favorites"."favoritor_id" = $1 AND "favorites"."favoritor_type" = $2 AND "favorites"."blocked" = $3 AND "favorites"."scope" = $4 AND "favorites"."favoritable_id" = $5 AND "favorites"."favoritable_type" = $6 ORDER BY "favorites"."id" ASC LIMIT $7 [["favoritor_id", 21], ["favoritor_type", "User"], ["blocked", false], ["scope", "Favorite"], ["favoritable_id", 7], ["favoritable_type", "Book"], ["LIMIT", 1]]
and it returns nil as it didn't find the record to delete.

2- when changing default scope to be Favorite instead of favorite everything is working perfectly.

[djaircarvalho]

@mhdrahmoun this issue was already solved in master. I suggest you use gem 'acts_as_favoritor', github: 'jonhue/acts_as_favoritor' in your Gemfile until @jonhue update the gem in rubygems.org

[jonhue]

Good point @djaircarvalho. Will do so. (#27)