Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add abstract DependencyConsumer base class for DI consumers #108

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

jonisavo
Copy link
Owner

This new base class should make it easier for non-UIComponent classes to use the built-in DI system.

@jonisavo jonisavo added the enhancement New feature or request label Sep 21, 2023
@jonisavo jonisavo added this to the 1.0 milestone Sep 21, 2023
@jonisavo
Copy link
Owner Author

This implements a part of #104.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #108 (d0b4979) into main (b6e219c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #108   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           54        55    +1     
  Lines         1641      1656   +15     
=========================================
+ Hits          1641      1656   +15     
Flag Coverage Δ
automated 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
Assets/UIComponents/Core/UIComponent.cs 100.00% <ø> (ø)
...nts/Core/DependencyInjection/DependencyConsumer.cs 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jonisavo jonisavo merged commit 424143b into main Sep 21, 2023
11 checks passed
@jonisavo jonisavo deleted the feature/dependency-consumer branch September 21, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant