Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

G4 error, Did you forget to signal async completion? #252

Open
azerafati opened this issue Jun 16, 2018 · 1 comment
Open

G4 error, Did you forget to signal async completion? #252

azerafati opened this issue Jun 16, 2018 · 1 comment

Comments

@azerafati
Copy link

I just switched to Gulp version 4, everything works fine except my useref task giving me error:

The following tasks did not complete:  dependencies-admin
 Did you forget to signal async completion?

If I remove the useref pipe it works perfectly fine

gulp.task('dependencies-admin', function (done) {

    return gulp.src(['app/view/admin/admin-index.php'], {base: '.'})

        .pipe(useref({searchPath: '.'}))    // if I comment this line  the error goes away

        .pipe(gulp.dest(destination));

});

for some reason useref is not signalling the end of it's task? have you tested it with G4? Am I missing something here?

@jonkemp
Copy link
Owner

jonkemp commented Jun 19, 2018

I think you either need to call done or don't pass it in. What happens if you try that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants