Add share option, refactoring + minor tweaks #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns menu syntax selector and the paste view popup syntax selector. - Fixed so that the title on the paste view popup syntax selector also updates when a syntax is chosen using the textfield search.
Shortened the post method slightly with a couple of ternary operators. Reversed Previous Pastes view order with latest paste at top now.
…on border attributes in the Attributes Inspector - Added borders to buttons on main view so buttons are more clearly... buttons :P - Separated buttons further from each other to stop possible miss-clicks - Edited text on buttons to make it more... "button like"? :P
…nks. NOTE: This needs to be tested on an actual device (I can't) as many of the apps that can be shared to are missing on simulator. Share should ideally be able to open in directly Safari however also as a string link into messenger, email and also external apps such as Twitter, Facebook, Slack among others. This feature needs to be tinkered with.
…of thin border. Set all segues to have same smooth transition to make it more uniform.
Set version to 1.8.1
…fit in better with rest of app. Changed transition to TextSelectionViewController to cross fade in line with rest of app.
Stacked main view buttons so that they, together, center on the screen rather than top button center.
Aecasorg
changed the title
|
@jonluca Cheers!
… On 27 Apr 2018, at 07:42, JonLuca De Caro ***@***.***> wrote:
Merged #15 <#15>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#15 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ATB5YyfZAoakMKf7rPxf4IAoNcG9qZtDks5tsq-1gaJpZM4Tklks>.
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added share option for Pastebin links.
Moved post functions to PastebinHelper class.
Smoothed transitions between all views to give more uniform flow.