-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fill sometimes fails (seemingly if word after break is quite long), seems a regression in 4.16 #17
Comments
Looks like this problem appeared in from the following change, made in
for which I cannot find a record in the RCS that Hugh sent me in Jan 2020, but which I see email about from that date, "Subject: test fire: jove 4.16.0.74", announcing ftp://ftp.cs.toronto.edu/pub/hugh/jove-dev/experimental/jove4.16.0.74.tgz The relevant change in paragraph.c, which, if reversed, fixes the problem (but presumably re-introduces whatever problem this change was intended to fix) is:
|
Fairly sure that #18 is a duplicate of this. I think I understand the issue (but hey, it's the Jove paragraph code, which, um, is like definitely in the top ten code paths in Jove that scare me). The problem with the test for out-of-range being before the if() is that it triggers when |
And the file is now |
didn't mean to close, leaving open for further comments or test cases where the older behavior was wrong. @HughR |
The above line does not wrap on fill-paragraph with
a right-margin >= 51 (i.e. right-margin-here on
the space after "need" If the right-margin is 50,
i.e. right-margin-here on the final character 'd'
of "need", then it correctly fills)
This fails on 4.16.0.74 and 4.17 head, seems to work on 4.14.11 (a tiny set of quite minimal changes -- rename getline -> jgetline, fix errno declaration -- to build 4.14.10 on Linux, to give us a very old baseline for this sort of regression)
The text was updated successfully, but these errors were encountered: