Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accomodate field documentation #6

Closed
sdewaele opened this issue Oct 30, 2020 · 3 comments
Closed

Accomodate field documentation #6

sdewaele opened this issue Oct 30, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@sdewaele
Copy link

Thanks for this package - it is very useful!

It would be great if the package would handle docstrings for field names, like so:

@concrete struct MyStruct
    "my field documentation"
    a
end

Currently, this results in an error:

ERROR: LoadError: MethodError: no method matching _parse_line(::String)
@jonniedie
Copy link
Owner

Oh that should be a pretty easy fix. Actually, I’m not sure why I didn’t put a fallback implementation of _parse_line for stuff like this. I don’t have a computer on me for the weekend, so if you are feeling adventurous, feel free to submit a pull request. If not, I’ll take care of it when I get back Monday.

@jonniedie jonniedie added the bug Something isn't working label Oct 31, 2020
@jonniedie
Copy link
Owner

Actually I just went ahead and did it on my phone. It was a pretty easy fix

@sdewaele
Copy link
Author

Thanks a lot, that was fast!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants