Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with Bootstrap 3.3.7 [class*="row"] #1

Closed
1 of 3 tasks
paavo opened this issue Nov 1, 2017 · 3 comments
Closed
1 of 3 tasks

Problems with Bootstrap 3.3.7 [class*="row"] #1

paavo opened this issue Nov 1, 2017 · 3 comments
Assignees

Comments

@paavo
Copy link

paavo commented Nov 1, 2017

This is a (multiple allowed):

  • bug
  • enhancement
  • feature-discussion (RFC)

Problem

class="jonnitto-imagesinarow__row" accidentally act's as Bootstrap .row because of the .container-fluid [class*="row"] selector.

Solution

A: Remove row from Classname "jonnitto-imagesinarow__row".
B: Use a configurable variable as classname

@jonnitto
Copy link
Owner

jonnitto commented Nov 1, 2017

Hi @drlimbo
Thank you for your issue. If I look at the source code of the Bootstrap CSS, I can't find a class like this. It looks like you add this by yourself. You should change the selector to .container-fluid .row

@jonnitto jonnitto self-assigned this Nov 1, 2017
@paavo
Copy link
Author

paavo commented Nov 2, 2017

im sorry @jonnitto!
looks like my co-worker added the code and i thought its coming from bootstrap..

@jonnitto
Copy link
Owner

jonnitto commented Nov 2, 2017

No problem. I recently released Version 1.1: Much smaller CSS footprint

@jonnitto jonnitto closed this as completed Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants