Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny gain in efficiency - point offset #15

Open
jonnyhuck opened this issue Mar 2, 2018 · 0 comments
Open

Tiny gain in efficiency - point offset #15

jonnyhuck opened this issue Mar 2, 2018 · 0 comments
Assignees
Labels
enhancement low priority Not a major enhancement / problem

Comments

@jonnyhuck
Copy link
Owner

Lines 742-747 of viewshed.cpp use pythagoras then a geometric offset to locate the top left corner of the area of interest, then they convert to coordinates in pixels (rather than units of the map projection).

This could be done more efficiently by simply minusing radius/2 from each coordinate and then converting to pixel coordinates.

This only happens once per calculation, so not a very high priority!

@jonnyhuck jonnyhuck added enhancement low priority Not a major enhancement / problem labels Mar 2, 2018
@jonnyhuck jonnyhuck self-assigned this Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement low priority Not a major enhancement / problem
Projects
None yet
Development

No branches or pull requests

1 participant