Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--force-submit requires internet connection #128

Closed
Freso opened this issue May 5, 2021 · 0 comments · Fixed by #129
Closed

--force-submit requires internet connection #128

Freso opened this issue May 5, 2021 · 0 comments · Fixed by #129

Comments

@Freso
Copy link
Collaborator

Freso commented May 5, 2021

I’ve been having some DNS troubles and used isrcsubmit.py --force-submit --browser=/usr/bin/echo to get submission URL to use on another machine, but it will fail whenever DNS lookup to MusicBrainz fails. I can’t think of a reason why --force-submit would need a connection to MusicBrainz at all.
Freso added a commit to Freso/musicbrainz-isrcsubmit that referenced this issue May 5, 2021
@Freso
Don’t make any WS2 requests for --force-submit
87de46a 
Move logic for checking for `option.force_submit` in
Disc.select_release() before fetching (potential) matching
releases in MusicBrainz.

This both speeds up the handling of `--force-submit` and also
decreases net load ever so slightly (probably unnoticeably),
both for the user and for MB. :)

Fixes JonnyJD#128
@Freso Freso mentioned this issue May 5, 2021
Merged
@Freso Freso closed this as completed in #129 May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don’t make any WS2 requests for --force-submit Freso/musicbrainz-isrcsubmit
1 participant
@Freso