-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selecting release and quitting program #32
Comments
There was a recent change in #26 Starting with 0 comes natural because this is how arrays work in python, but adding an offset of 1 is possible. Why do you use a dos.bat and why do you catch |
My I still need I agree 0 for exit is not good. Actually in |
Well, at the time isrcsubmit asks you for the release, any invalid input will just exit. (just like in isrcsubmit.exe) However, later on in the script, like when asked for the offset, it will only exit on CTRL-C, because you might not want to exit on a whim after reading the ISRCs and making a couple of choices. |
I don't really think it matter whether we're counting from 0 or 1. Whichever is more intuitive for the coder. This is a CLI script. It's not going to be something Windows users at large will use. It's not going to be as widely "popular" as Picard. It's a niche script for crazy, obsessive-compulsive editors that wants to add everything. So. Just keep Python's own array numbering instead of adding more code (that will also need to be kept updated, ported to Py3 at some point, etc.) for little to no gain. IMHO. |
Forget the key to quit, I thought it didn’t quit when just pressing ENTER key but it actually does… |
You eventually still don’t like it to number choices from 1 instead of from 0, then ? |
To be fair, I don't know what most users prefer. I don't get that much feedback and the feedback I get is mostly from users at github (where many are devs/tech-savy). I only know that using 1 to n is a major source of bugs in general, especially because this is a small (1 file) script without a separate user interface. The logic and the interface are tightly coupled. That being said, I will change it anyways, since it does seem to be more than a minor annoyance to you and possibly others. |
Fixed. Should be in the next (feature) release |
Thanks very much for this personal fix! :) |
Could it be possible to start the release number from 1 instead of from 0 in please select your release
And could we have the 0 for quitting program (no other way than
CTRL+C
now, and this is not good result when using ados.bat
file which then asks for quit confirm).The text was updated successfully, but these errors were encountered: