make isrcsubmit at least partially python3-compliant before the 2.0 fork #45

JonnyJD · 2013-01-26T10:07:09Z

To keep backporting easy, we should try to make obvious fixes to the 1.0 branch to work mostly in python3 before we fork 1.0 to work on 2.0.

That includes:

print "as a function" (in python2 with only 1 argument = no actual tuple/arglist, be aware of newlines!)
except Error AS err
raw_input -> input (try input = raw_input except: pass)

note: python-musicbrainz2 only works with Python 2 (though it imports fine), so this won't help isrcsubmit 1.0 to work with Python 2. We should test that anyways.

This makes it easier to backport things when we fork 1.0 to work on 2.0 print x can be written as print(x) even in Python 2, because this is just taken as additional parentheses around x. print x, y can be written with print("%s %s" % (x, y)). print can be written as print(""). print() would print "()" on python 2. This doesn't work easily when we don't want a newline after the ouput. So no change is made for these cases.

Python 3 has input = raw_input and no raw_input anymore. On Python 2 we will have problems with empty input on "input", so we have user_input which chooses the method accordingly.

JonnyJD added a commit that referenced this issue Jan 26, 2013

make input work in Python 3, re #45

1caeed1

Python 3 has input = raw_input and no raw_input anymore. On Python 2 we will have problems with empty input on "input", so we have user_input which chooses the method accordingly.

JonnyJD closed this as completed in e00afb1 Jan 26, 2013

ghost assigned JonnyJD Jan 26, 2013

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

make isrcsubmit at least partially python3-compliant before the 2.0 fork #45

make isrcsubmit at least partially python3-compliant before the 2.0 fork #45

JonnyJD commented Jan 26, 2013

make isrcsubmit at least partially python3-compliant before the 2.0 fork #45

make isrcsubmit at least partially python3-compliant before the 2.0 fork #45

Comments

JonnyJD commented Jan 26, 2013