Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider using discid_read_sparse when/if implemented in libdiscid #19

Closed
JonnyJD opened this issue Mar 1, 2013 · 2 comments
Closed
Assignees
Milestone

Comments

@JonnyJD
Copy link
Owner

JonnyJD commented Mar 1, 2013

http://tickets.musicbrainz.org/browse/LIB-29 is quite new and probably still takes some time.

However, if we include that together with the ISRC API addition, then we might circumvent performance problems later on.
So everybody who only wants the id can use read() now and we will make simple reads faster when LIB-29 is implemented.
Later we can introduce an optional mode option where you have to tell if you want ISRCs and the "ID users" don't have to change anything.

@JonnyJD
Copy link
Owner Author

JonnyJD commented Mar 1, 2013

This still needs decision for how to use the mode option.

Bit masks aren't any good for a clean python interface, or are they?

String lists would have the advantage, that we can just pass FEATURES when we don't care about performance and want everything. The feature strings are stable (taken from discid.h).

@ghost ghost assigned JonnyJD Apr 7, 2013
@JonnyJD
Copy link
Owner Author

JonnyJD commented Apr 7, 2013

Implemented in c998986 (#10).

There is now an optional features parameter that accepts a list of strings.

@JonnyJD JonnyJD closed this as completed Apr 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant