Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing data attributes output in helper tool #60

Merged
merged 1 commit into from May 23, 2017
Merged

Fixing data attributes output in helper tool #60

merged 1 commit into from May 23, 2017

Conversation

cavemon
Copy link
Contributor

@cavemon cavemon commented May 23, 2017

I noticed that the helper tool was outputting incorrect data attributes for width and height.

  • "focus-w" -> "image-w"
  • "focus-h" -> "image-h"

@jonom jonom merged commit 51087f2 into jonom:master May 23, 2017
@jonom
Copy link
Owner

jonom commented May 23, 2017

Thanks!

@cavemon
Copy link
Contributor Author

cavemon commented May 23, 2017

@jonom thank you! Appreciate the work you've done with this plugin! :)

@cavemon
Copy link
Contributor Author

cavemon commented Jun 9, 2017

@jonom the jquery.focuspoint.helpertool.js needs to be pushed to the demo as well: http://jonom.github.io/jquery-focuspoint/demos/helper/index.html

@jonom
Copy link
Owner

jonom commented Jun 12, 2017

Ah yes, have pushed that up now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cavemon @jonom