Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi-outputs, add new outputs #124

Closed
jonrau1 opened this issue May 14, 2023 · 0 comments · Fixed by #129
Closed

Fix multi-outputs, add new outputs #124

jonrau1 opened this issue May 14, 2023 · 0 comments · Fixed by #129
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request

Comments

@jonrau1
Copy link
Owner

jonrau1 commented May 14, 2023

So ElectricEye is supposed to support multiple outputs...but it uhh...doesn't. Fix that.

Also, since requests is pre-package we can mess with webhooks

Outputs types

  • SQS: This was promised...not delivered
  • DynamoDB: well, fix the one in there
  • Slack Summary: Slack webhook to shoot a summary of findings, assets scanned, compliance percentages
  • Teams Summary: Teams webhook to shoot a summary of findings, assets scanned, compliance percentages
  • Slack findings: TOML needs a filter of what severity to send, default to HIGH + CRITICAL? There are lot of Highs in EE...
  • Teams findings: Same

For #123 I have to add GCS & S3 plus add new CLI args -- find a way to re-use those to control sending outputs over to GCS or S3. So if someone specifies -o json --output-file my-electric-json-for-s3 they could use the --config-location arg to have it uploaded to s3

Should definitely not call it --config-location

Wow, so many overlapping systems

@jonrau1 jonrau1 added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels May 14, 2023
@jonrau1 jonrau1 self-assigned this May 14, 2023
@jonrau1 jonrau1 added this to To do in ElectricEye Roadmap via automation May 14, 2023
@jonrau1 jonrau1 moved this from To do to Doing in ElectricEye Roadmap May 31, 2023
ElectricEye Roadmap automation moved this from Doing to Done Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
1 participant