Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove bracket on gherkin generator #280

Conversation

golane-august
Copy link

@golane-august golane-august commented Dec 29, 2022

The generator is currently not working, as the bracket was not removed in my proposes from here:
#279 (comment)

CC @AFASbart

@rhalff
Copy link

rhalff commented May 17, 2023

@jonsamwell this PR still needs to merge, generating the files will give a formatter parse error otherwise. It's due to some previous commits fiddling within that area.

@AFASbart
Copy link
Collaborator

AFASbart commented May 17, 2023

I have it approved, @jonsamwell needs to approve it aswell and then create a new version. For the time being you can work with your own branch version:

  flutter_gherkin:
    git:
      url: https://github.com/golane-august/flutter_gherkin.git
      ref: fix/remove-bracket-generator

@julianryorex
Copy link

What is the ETA on this?

@jonsamwell jonsamwell merged commit d15ec4c into jonsamwell:integration_test__package_support Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants