Optimized code in injector and added a possibility for method chaining #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a possibility to chain method calls using cascade operator.
|
Thanks for this, the code looks good. I'll have a bit of time to merge this in tomorrow and do a new release. Is this test still passing? |
|
Yes, test is still passing of course. Many thanks too!
Jon Samwell <notifications@github.com> schrieb am Fr., 23. Okt. 2020, 10:40:
… Thanks for this, the code looks good. I'll have a bit of time to merge
this in tomorrow and do a new release.
Is this test still passing?
https://github.com/jonsamwell/flutter_simple_dependency_injection/blob/master/test/flutter_simple_dependency_injection_test.dart#L199
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#15 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAF3KZS6DRLWKZLOIGWAJPDSME6QPANCNFSM4SZYMHJQ>
.
|
…shorter by the factory constructor
|
@jonsamwell I've updated this pull request. The Injector class has a factory constructor now. An Injector instance can be instantiated more shorter. "Injector.getInjector()" is marked as deprecated as discussed here #16 I've updated CHANGELOG too. Looking forward for a new release! |
|
@ova2 many thanks for this PR. Released as version 1.0.4 |
|
@jonsamwell Many thanks for release too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use a fork of your great library with some patched code which I now committed in this PR. All tests are green.
Thanks for accepting this PR in advance. I would be happy if you could release a new version of this lib.