Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General failure #4

Closed
ain opened this issue Jun 26, 2016 · 2 comments
Closed

General failure #4

ain opened this issue Jun 26, 2016 · 2 comments

Comments

@ain
Copy link
Contributor

ain commented Jun 26, 2016

Step to reproduce:

  1. Create banner.js:

    var banner = require('add-banner');
    console.log('Adding banner to smartbanner.min.js');
    banner('./dist/smartbanner.min.js', {username: 'ain'});
  2. Create NPM script bannerise with node banner.js

  3. Run npm run bannerise

What happens:

$ npm run bannerise

> smartbanner.js@0.0.1 bannerise /Users/ain/Documents/projects/smartbanner.js
> node banner.js

Adding banner to smartbanner.min.js

Nothing is written to dist/smartbanner.min.js.

What should happen: default banner should be written to dist/smartbanner.min.js in respect to package.json.

Platform:

$ node --version
v6.2.0
@ain
Copy link
Contributor Author

ain commented Jun 26, 2016

My bad. One has to handle banner() output manually.

Module could use a CLI in a bin/ to automate this for the NPM scripts.

@ain ain closed this as completed Jun 26, 2016
@jonschlinkert
Copy link
Owner

Module could use a CLI in a bin/ to automate this for the NPM scripts.

I was going to say that in the tweet, I agree. I thought I did add a CLI, I guess not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants